Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls-nopic test fails with mold 1.6.0 on i686 #794

Closed
jpalus opened this issue Oct 19, 2022 · 5 comments
Closed

tls-nopic test fails with mold 1.6.0 on i686 #794

jpalus opened this issue Oct 19, 2022 · 5 comments

Comments

@jpalus
Copy link
Contributor

jpalus commented Oct 19, 2022

Single test failed on i686:

Testing tls-nopic ... ++ t=out/test/elf/i386/tls-nopic
++ mkdir -p out/test/elf/i386/tls-nopic
+ cat
+ gcc -c -o out/test/elf/i386/tls-nopic/a.o -xc -
+ cat
+ cc -xc -c -o out/test/elf/i386/tls-nopic/b.o -
+ cc -B. -o out/test/elf/i386/tls-nopic/exe out/test/elf/i386/tls-nopic/a.o out/test/elf/i386/tls-nopic/b.o
mold: fatal: out/test/elf/i386/tls-nopic/a.o:(.text): TLS_GD reloc must be followed by PLT or GOT32
collect2: error: ld returned 1 exit status
++ on_error 26
++ code=1
++ echo 'command failed: 26: $CC -B. -o $t/exe $t/a.o $t/b.o'
command failed: 26: $CC -B. -o $t/exe $t/a.o $t/b.o
++ trap - EXIT
++ exit 1
<end of output>
Test time =   0.08 sec
----------------------------------------------------------
Test Failed.
"i686-tls-nopic" end time: Oct 19 11:49 CEST
"i686-tls-nopic" time elapsed: 00:00:00
----------------------------------------------------------
@rui314
Copy link
Owner

rui314 commented Oct 19, 2022

Can you upload your out/test/elf/i386/tls-nopic/a.o?

@jpalus
Copy link
Contributor Author

jpalus commented Oct 19, 2022

Attached.
a.o.zip

@rui314 rui314 closed this as completed in 2aa2494 Oct 19, 2022
@jpalus
Copy link
Contributor Author

jpalus commented Oct 19, 2022

@rui314 Thanks for the fix. While linking passes now, the test still fails as resulting binary segfaults.
exe.zip

rui314 added a commit that referenced this issue Oct 19, 2022
@rui314
Copy link
Owner

rui314 commented Oct 19, 2022

Yeah, sorry, it should be fixed with the above commit.

@jpalus
Copy link
Contributor Author

jpalus commented Oct 19, 2022

With both fixes all tests passed. Thanks!

pld-gitsync pushed a commit to pld-linux/mold that referenced this issue Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants