Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting rows and columns are not working #120

Closed
gudipudipradeep opened this issue Dec 8, 2022 · 4 comments · Fixed by #124
Closed

Limiting rows and columns are not working #120

gudipudipradeep opened this issue Dec 8, 2022 · 4 comments · Fixed by #124

Comments

@gudipudipradeep
Copy link
Contributor

"row": 36, //the number of rows in a sheet
"column": 18, //the number of columns in a sheet

set the attributes as per the document https://ruilisi.github.io/fortune-sheet-docs/guide/sheet.html#initial
followed the above document
got more rows and columns
image

@shuanhukexuejia
Copy link
Collaborator

Have fixed it, will commit it later

@gudipudipradeep
Copy link
Contributor Author

@Qaplagzy @shuanhukexuejia is this changes are released as part of 0.11.0 version. because I couldn't see the reflection in 0.11.0

@shuanhukexuejia
Copy link
Collaborator

shuanhukexuejia commented Dec 26, 2022

@gudipudipradeep
image

image

Try to create an empty sheet.

@gudipudipradeep
Copy link
Contributor Author

gudipudipradeep commented Dec 29, 2022

@shuanhukexuejia it working as you given but not working as sheet based configuration below.
<Workbook ref={workbookRef} data={data} row={10} column={22} addRows={10} onOp={onOp} onChange={onChange} hooks={{ afterSelectionChange,}} />

but not working as sheet based configuration as per the document.
https://ruilisi.github.io/fortune-sheet-docs/guide/sheet.html#initial
like
`const settings = [
{
name: "Terminal",
id: 0,
status: 1,
defaultRowHeight: 20,
scrollLeft: 0,
row: 20,
column: 10,

},
{
"name": "Calculation",
"color": "",
"id": "2",
"status": 0,
"order": 2,
"celldata": [],
"config": {},
row: 10,
column: 10,
},
{
"name": "General",
"color": "",
"id": "3",
"status": 0,
"order": 2,
"celldata": [],
"config": {},
row: 15,
column: 30,
}
];
<Workbook ref={workbookRef} data={settings} onOp={onOp} onChange={onChange} hooks={{ afterSelectionChange,}} />
`
It will helpful based on sheet based configuration. Please can you conform once if I am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants