New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending m.room.member and m.presence events again after changing avatar or displayname #157

Open
farodin91 opened this Issue Jan 10, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@jooert

This comment has been minimized.

Contributor

jooert commented Mar 21, 2017

Perhaps I'm misunderstanding something here, but isn't that already implemented? Avatar and display name can only be changed through the /profile API and the handlers for PutAvatarUrl and PutDisplayName both call models::profile::Profile::update_memberships which then calls RoomMembership::update which finally emits an m.room.member event.

@mujx

This comment has been minimized.

Contributor

mujx commented Mar 22, 2017

@jooert Seems you are right regarding the m.room.member event. Reading through the code the issue seems to be about the m.presence event also.

The problems is in PresenceStatus::upsert which is called after a profile update. Here we create the event_id but we don't use it to create the actual event in PresenceStatus::update (like we do in PresenceStatus::create) which leave us with a dangling event_id.

@mujx mujx changed the title from Sending a m.room.member event again after changing avatar or displayname to Sending a m.room.member and m.presence events again after changing avatar or displayname Mar 22, 2017

@mujx mujx changed the title from Sending a m.room.member and m.presence events again after changing avatar or displayname to Sending m.room.member and m.presence events again after changing avatar or displayname Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment