Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor large blocks of Api::to_tokens into separate functions #104

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

DevinR528
Copy link
Member

No description provided.

Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is purely cut-and-paste, no (intentional) logic changes, right?

ruma-api-macros/src/api/attribute.rs Show resolved Hide resolved
ruma-api-macros/src/util.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/util.rs Outdated Show resolved Hide resolved
@DevinR528
Copy link
Member Author

Correct, I wanted to break it up it was harder for me to follow along as one big block.

@DevinR528 DevinR528 force-pushed the ruma_api-refactor branch from f54a60e to 3830ebb Compare July 1, 2020 21:05
@jplatte jplatte merged commit b08b1d1 into ruma:master Jul 1, 2020
@DevinR528 DevinR528 deleted the ruma_api-refactor branch May 3, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants