Skip to content

Add guard in ruma_api! macro for non-ASCII in path#105

Merged
jplatte merged 6 commits intoruma:masterfrom
DevinR528:invalid-path
Jul 2, 2020
Merged

Add guard in ruma_api! macro for non-ASCII in path#105
jplatte merged 6 commits intoruma:masterfrom
DevinR528:invalid-path

Conversation

@DevinR528
Copy link
Copy Markdown
Member

Returns a compiler error if any non-ASCII characters are found. Add trybuild test for invalid path characters.

Returns a compiler error if any non ASCII characters are found. Add
trybuild test for invalid path characters.
Comment thread ruma-api-macros/src/api.rs Outdated
Comment thread ruma-api-macros/src/api/metadata.rs Outdated
Comment thread ruma-api/tests/ui/02-invalid-path.rs Outdated
Comment thread ruma-api-macros/src/util.rs Outdated
Comment thread ruma-api-macros/src/util.rs Outdated
Comment thread ruma-api/tests/ui/02-invalid-path.rs Outdated
Comment thread ruma-api-macros/src/api/metadata.rs Outdated
@jplatte
Copy link
Copy Markdown
Member

jplatte commented Jul 2, 2020

Thanks! Will merge once CI is happy.

@jplatte jplatte merged commit 214c1b6 into ruma:master Jul 2, 2020
@DevinR528 DevinR528 deleted the invalid-path branch May 3, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants