Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard in ruma_api! macro for non-ASCII in path #105

Merged
merged 6 commits into from Jul 2, 2020

Conversation

DevinR528
Copy link
Member

@DevinR528 DevinR528 commented Jul 2, 2020

Returns a compiler error if any non-ASCII characters are found. Add trybuild test for invalid path characters.

Returns a compiler error if any non ASCII characters are found. Add
trybuild test for invalid path characters.
ruma-api-macros/src/api.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/api/metadata.rs Outdated Show resolved Hide resolved
ruma-api/tests/ui/02-invalid-path.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/util.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/util.rs Outdated Show resolved Hide resolved
ruma-api/tests/ui/02-invalid-path.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/api/metadata.rs Outdated Show resolved Hide resolved
@jplatte
Copy link
Member

jplatte commented Jul 2, 2020

Thanks! Will merge once CI is happy.

@jplatte jplatte merged commit 214c1b6 into ruma:master Jul 2, 2020
3 checks passed
@DevinR528 DevinR528 deleted the invalid-path branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants