-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deserialization of redacted aliases events #128
Conversation
Nice! :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really don't want us hardcoding specific event types into the macro code. I guess we could always fall back to deserializing from an empty object instead of doing that only for m.room.aliases
. That doesn't feel like a very clean solution though. Ideas? ^^°
Yeah I kinda figured you wouldn't be thrilled with that. Well after thinking about it all evening yesterday the only thing I came up with was adding another trait method to Also documenting that the |
Okay, maybe we should just go at this in fully generality. I think that would mean adding
Actually, since we only need |
9761860
to
511cc8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two doc tiny errors that I will apply, this is looking good.
GitHub is having issues, I rebased/squashed and pushed manually. |
Cool! |
I split the first commit into 2, I got the hang of I think!