Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename *EventStub -> Sync*Event #130

Closed
wants to merge 2 commits into from
Closed

Conversation

DevinR528
Copy link
Member

@DevinR528 DevinR528 commented Jul 14, 2020

I should also rename PduStub to SyncPdu right?

@jplatte
Copy link
Member

jplatte commented Jul 14, 2020

I should also rename PduStub to SyncPdu right?

I wonder why we need that type actually. But yeah, it would be weird to still have Stub somewhere when "missing room_id" is otherwise signified by the Sync prefix everywhere.

@DevinR528
Copy link
Member Author

DevinR528 commented Jul 14, 2020

In my find and replace looking around it seems they are used for federation endpoints.

https://github.com/ruma/ruma/blob/master/ruma-federation-api/src/membership/create_join_event/v1.rs

@jplatte
Copy link
Member

jplatte commented Jul 14, 2020

Oh right. Yeah, it is weird renaming that since the room_id missing there has nothing to do with /sync, only with the room id being a path parameter rather than a body parameter. We should probably eventually find a way for that to work without the extra stub type, or with the stub type only being an implementation detail.

@jplatte
Copy link
Member

jplatte commented Jul 14, 2020

I've cherry-picked the first commit, thanks for this! :)

@jplatte jplatte closed this Jul 14, 2020
@DevinR528 DevinR528 deleted the sync-rename branch Jul 14, 2020
@DevinR528 DevinR528 mentioned this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants