Add UnsignedSync type to accomadate for sync events#135
Merged
Conversation
Rename UnsignedData -> Unsigned
jplatte
reviewed
Jul 15, 2020
Member
There was a problem hiding this comment.
So this would probably work but really it doesn't make that much sense to have most of this for redaction events. If we're splitting it like this anyway, let's have Unsigned for non-redacted events (without redacted_because), RedactedUnsigned with just redacted_because and RedactedSyncUnsigned with just redacted_because but a different redaction event type. Makes sense?
EDIT: Alternatively, have just Unsigned and RedactedUnsigned, but the latter generic, e.g. RedactedSyncStateEvents unsigned would have the type RedactedUnsigned<SyncRedactionEvent>.
Member
|
If you don't see any issues with what I wrote above, can you add |
DevinR528
changed the title
These two new unsigned types only have a redacted_because field and the Unsigned stuct's redacted_because field has been removed.
jplatte
changed the title
jplatte
reviewed
Jul 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #118