Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnyPossiblyRedacted* enums to the code-gen of event_enum! #139

Merged
merged 2 commits into from Jul 17, 2020

Conversation

DevinR528
Copy link
Member

@DevinR528 DevinR528 commented Jul 17, 2020

Are there any methods that should be added to these enums? Nothing I can think of would be all that helpful.

The first commit is the actual work then I copy pasted things around but no changes.
Resolves #119

@jplatte
Copy link
Member

jplatte commented Jul 17, 2020

Huh, I didn't actually think we'd generate these but it does make sense since that's easy to do. Really wonder whether we shouldn't just move everything into one macro invocation and generate the other enums of specific event kind enums too.

@jplatte
Copy link
Member

jplatte commented Jul 17, 2020

Gonna trust you that that second commit is just moving things around, diff is not particularily easy to read.

@jplatte jplatte merged commit 848b225 into ruma:master Jul 17, 2020
3 checks passed
@DevinR528
Copy link
Member Author

DevinR528 commented Jul 17, 2020

I bet we could move to the "one big macro" without changing the expansion logic just adding some parsing code to make it all work. That could be done at anytime right, since it wouldn't be a breaking change to anything?

@jplatte
Copy link
Member

jplatte commented Jul 17, 2020

I bet we could move to the "one big macro" without changing the expansion logic just adding some parsing code to make it all work.

I think so too.

That could be done at anytime right, since it wouldn't be a breaking change to anything?

Yes.

@DevinR528 DevinR528 deleted the possibly-redacted branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants