Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the attributes of any type deriving Outgoing to the Incoming type #190

Merged
merged 1 commit into from
Aug 9, 2020
Merged

Pass the attributes of any type deriving Outgoing to the Incoming type #190

merged 1 commit into from
Aug 9, 2020

Conversation

DevinR528
Copy link
Member

Resolves #187

jplatte
jplatte reviewed Aug 9, 2020
View reviewed changes
ruma-api-macros/src/derive_outgoing.rs Outdated
@@ -114,6 +119,12 @@ pub fn expand_derive_outgoing(input: DeriveInput) -> syn::Result<TokenStream> {
}
}

/// Keep any `serde(untagged)` or `non_exhaustive` attributes found and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily just untagged.

Suggested change
/// Keep any `serde(untagged)` or `non_exhaustive` attributes found and
/// Keep any `serde` or `non_exhaustive` attributes found and

@jplatte jplatte merged commit ddb1b48 into ruma:master Aug 9, 2020
@DevinR528 DevinR528 deleted the pass-attributes branch May 3, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outgoing derive macro fails to copy serde container attributes to the incoming type
2 participants
@DevinR528 @jplatte