Skip to content

Pass the attributes of any type deriving Outgoing to the Incoming type#190

Merged
jplatte merged 1 commit intoruma:masterfrom
DevinR528:pass-attributes
Aug 9, 2020
Merged

Pass the attributes of any type deriving Outgoing to the Incoming type#190
jplatte merged 1 commit intoruma:masterfrom
DevinR528:pass-attributes

Conversation

@DevinR528
Copy link
Copy Markdown
Member

Resolves #187

Comment thread ruma-api-macros/src/derive_outgoing.rs Outdated
Comment thread ruma-api-macros/src/derive_outgoing.rs Outdated
}
}

/// Keep any `serde(untagged)` or `non_exhaustive` attributes found and
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily just untagged.

Suggested change
/// Keep any `serde(untagged)` or `non_exhaustive` attributes found and
/// Keep any `serde` or `non_exhaustive` attributes found and

@jplatte jplatte merged commit ddb1b48 into ruma:master Aug 9, 2020
@DevinR528 DevinR528 deleted the pass-attributes branch May 3, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Outgoing derive macro fails to copy serde container attributes to the incoming type

2 participants