Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the attributes of any type deriving Outgoing to the Incoming type #190

merged 1 commit into from Aug 9, 2020


Copy link

@DevinR528 DevinR528 commented Aug 9, 2020

Resolves #187

@@ -114,6 +119,12 @@ pub fn expand_derive_outgoing(input: DeriveInput) -> syn::Result<TokenStream> {

/// Keep any `serde(untagged)` or `non_exhaustive` attributes found and
Copy link

@jplatte jplatte Aug 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily just untagged.

Suggested change
/// Keep any `serde(untagged)` or `non_exhaustive` attributes found and
/// Keep any `serde` or `non_exhaustive` attributes found and

@jplatte jplatte merged commit ddb1b48 into ruma:master Aug 9, 2020
3 checks passed
@DevinR528 DevinR528 deleted the pass-attributes branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

2 participants