Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional header values in request/response types #234

Merged
merged 5 commits into from Aug 21, 2020

Conversation

DevinR528
Copy link
Member

@DevinR528 DevinR528 commented Aug 20, 2020

Resolves #9

Copy link
Member

@jplatte jplatte left a comment

Lots of small nits, but overall looks good!

ruma-api-macros/src/api/request.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/api/request.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/api/request.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/api/request.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/api/request.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/api/response.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/api/response.rs Outdated Show resolved Hide resolved
ruma-api-macros/src/api/response.rs Outdated Show resolved Hide resolved
@jplatte jplatte changed the title Optional header values in reqeust/response types Optional header values in request/response types Aug 21, 2020
@jplatte jplatte merged commit a8b4bad into ruma:master Aug 21, 2020
3 checks passed
@DevinR528 DevinR528 deleted the optional-header branch May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants