Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Edu enum to represent EDUs from /federation/v1/send #503

Merged
merged 6 commits into from Apr 16, 2021
Merged

Create Edu enum to represent EDUs from /federation/v1/send #503

merged 6 commits into from Apr 16, 2021

Conversation

DevinR528
Copy link
Member

@DevinR528 DevinR528 commented Apr 13, 2021 •
edited by jplatte

Resolves #492.

jplatte
jplatte reviewed Apr 16, 2021
View reviewed changes
ruma-federation-api/src/transactions/edu.rs Outdated

/// Event type for the message.
#[serde(rename = "type")]
pub ev_type: String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ruma_events::EventType?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if it was the same thing but it appears to be. I fixed it.

ruma-federation-api/src/transactions/edu.rs Outdated Show resolved Hide resolved
@jplatte jplatte merged commit 992266b into ruma:main Apr 16, 2021
@DevinR528 DevinR528 deleted the edu-send branch May 3, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte left review comments

@ShadowJonathan ShadowJonathan ShadowJonathan left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give /send edus proper types
3 participants
@DevinR528 @jplatte @ShadowJonathan