Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ruma-client as thin as possible #539

Merged
merged 20 commits into from
May 1, 2021
Merged

Make ruma-client as thin as possible #539

merged 20 commits into from
May 1, 2021

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Apr 26, 2021

Resolves #401.

Left to do:

  • Implement HttpClient for reqwest::Client
  • Add a Dummy http client for doctests
  • Update doctests to use http_client::Dummy.
  • Make sure this actually works by integrating it (for example into matrix-rust-sdk)
  • Re-export ruma-client from ruma
  • Have a brief look at what is required for appservice-api integration

@jplatte jplatte force-pushed the ruma-client-next branch 3 times, most recently from b067cbf to 337198c Compare April 26, 2021 22:31
@jplatte
Copy link
Member Author

jplatte commented Apr 27, 2021

Support for reqwest added, would be bit simpler with upstream support for the conversion (seanmonstar/reqwest#1258).

@jplatte jplatte force-pushed the ruma-client-next branch 2 times, most recently from 25948b9 to bdb3827 Compare April 29, 2021 17:59
@jplatte jplatte marked this pull request as ready for review May 1, 2021 19:23
@jplatte jplatte merged commit 92826df into main May 1, 2021
@jplatte jplatte deleted the ruma-client-next branch May 1, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow different http client implementations
1 participant