Add client secret and session ID identifier types. - #640
Conversation
|
If there is validation to be done, it should work like |
0933865 to
cd98469
Compare
|
If the changes I made are more in line with how it should be, then I think it would be a good idea to use a macro for it. I haven't ever written macros before, but I would be happy to try. Would it be just adding a macro like |
jplatte
left a comment
There was a problem hiding this comment.
Left some comments, but nothing fundamental. Please go ahead with creating the macro 🙂
Would it be just adding a macro like
opaque_identifierwith an extra argument being the validator function?
Exactly 👍🏼
jplatte
left a comment
There was a problem hiding this comment.
Needs a rebase (should be relatively easy).
Add macro and use it for ClienSecret and SessionId.
57fa4f3 to
70c5811
Compare
70c5811 to
fd097bb
Compare
|
I've updated the base branch since this is a breaking change (for ruma-identity-service-api). |
Resolves: #517
I'm not sure if I've gone the right way about adding the types. I used the
opaque_identifier!macro since the new types were similar to theKeyNametype. Would it be better to define them manually and/or add constructors to them and validate them simultaneously?