Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: Make all pub enums non_exhaustive #648

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

DevinR528
Copy link
Member

So anything that had a _Custom(String) variant I added the as_str method to... let me know what you think?

@DevinR528 DevinR528 requested a review from jplatte as a code owner June 26, 2021 12:08
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing as one the ruma-common PR re. about the cfg_attr applies here, otherwise LGTM.

@jplatte jplatte changed the base branch from main to next June 29, 2021 21:43
@jplatte jplatte merged commit 0d77829 into ruma:next Jun 29, 2021
@DevinR528 DevinR528 deleted the event-nonexh-enum branch June 29, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants