Update endpoints for blurhash implementation. - #650
Conversation
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Comments on get_avatar_url apply to the other two modified modules as well.
|
Changed the base branch to main since this can (and should) be done in a backwards-compatible manner. You can |
iinuwa
left a comment
iinuwa
left a comment
There was a problem hiding this comment.
(Sorry for the late response.)
It looks like the changes to GET /_matrix/federation/v1/query/profile are missing. The previous implementation also only implemented the blurhash response field for PUT /_matrix/media/r0/upload, but not the generate_blurhash request query parameter.
The types are also missing for the m.sticker and m.room.member events.
I've added the missing field for |
DevinR528
left a comment
DevinR528
left a comment
There was a problem hiding this comment.
Everything looks good to me (as long as the other review is done, which it looks like you got it all)! Good catch with the gated fields that was a tricky one.
iinuwa
left a comment
iinuwa
left a comment
There was a problem hiding this comment.
I think m.sticker has already been dealt with. m.sticker uses ruma_events::room::ImageInfo, which already has a blurhash field.
Ah, yes. My bad.
This looks good to me! I haven't looked at the #[cfg] attribute issue in depth, but I assume we'll need to wait for #659 to be merged before merging this one.
|
#659 has been merged and CI adjusted to also check most things without unstable-pre-spec. This just needs a rebase now. |
Add blurhash to profile and avatar endpoints.
Add `blurhash` fields to `GET /_matrix/federation/v1/query/profile` and `m.room.member`. Add `generate_blurhash` field to `PUT /_matrix/media/r0/upload`.
4 participants
Add blurhash to profile and avatar endpoints.
Resolves: #450