Add "knock" feature.#657
Merged
Merged
Conversation
jplatte
reviewed
Jul 2, 2021
jplatte
reviewed
Jul 3, 2021
jplatte
reviewed
Jul 3, 2021
jplatte
force-pushed
the
next
branch
2 times, most recently
from
b1d9872 to
70a2cd6
Compare
Member
|
I don't see any breaking changes, can you rebase on main and change the PR base branch too? |
Feature-gate changes behind `unstable-pre-spec`. Add missing constructors. Fix style issues and links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #479
I've based it off of
nextbranch since I assume this is supposed to contain breaking changes. Although I'm not sure if it should be feature-gated behindunstable-pre-specsince the MSC has already been merged.