Add field accessor code-gen for the event_enum! macro#97
Merged
Conversation
jplatte
reviewed
Jun 25, 2020
jplatte
reviewed
Jun 29, 2020
DevinR528
commented
Jun 29, 2020
Refactor all accessor method code gen in event_enum! macro. Add const array of (field_str, has_field_function).
jplatte
reviewed
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 9 events kinds so I could switch the
if/elseblocks of anyone that has more than 4||? that may shorten it some. Not sure what the best way to go about this is.