You can clone with
No one assigned
The only issue I've seen with this gem is that it doesn't set an Expires HTTP header to the far-future when it uploads the assets to S3. This would be a great performance enhancement.
I may work on adding this myself, but I wanted to make sure that this was an appropriate addition.
I'd like this as well, and would be willing to work on it, too.
Hey @mattvanhorn @supapuerco, you guys want to try out this branch I just put together? It includes two tweaks that should integrate Expires HTTP Header support and also adds cache control public.
Stick this in yer Gemfile.
gem 'asset_sync', :git => 'git://github.com/rumblelabs/asset_sync.git', :branch => 'cache-expiry'
Sets the headers perfectly.
Looking forward to getting this merged in.
Btw, this gem is awesome.
@wnadeau Cheers! Released Version 0.2.8 including these changes for you guys. Enjoy.
Is it me or this doesn't work?
I didn't do anything special, I sync my assets to s3 on an application hosted on heroku, and my files don't have expires headers.
@Papipo Not just you, I'm noticing the same with a similar setup. I'm going to switch over to the other branch and test it out. I'll post back after...
Agreed — appears to not work for me either.
Seeing the same thing on our app as well. Looks like Amazon must've changed something.
@pixelsonly any news?
Sorry for the late response, things are working perfect now!
Date:Sat, 19 Jan 2013 00:01:57 GMT
Expires:Sun, 19 Jan 2014 05:38:05 GMT
Last-Modified:Fri, 18 Jan 2013 23:38:06 GMT
It must have been a S3 problem. I haven't updated asset_sync but now the correct headers are there.
Has this stopped working again? I'm not seeing any expires headers being set on my assets.
Would using a non-default S3 region affect anything?
Expiration header not set for me either. Using default region with asset_sync. Any news on this?
I've fixed this in my pull request: #223 . +1s are welcome