Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unix sockets into /tmp. #101

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@yarlB
Copy link

commented May 4, 2018

Suggestion:
3 tests failed in my environment because rump server init failed: File name too long.
Actually, the limit for a unix socket's path length is quite small.
For example on NetBSD, according to unix(4) man page:

UNIX-domain addresses are variable-length filesystem pathnames of at most 104 characters.

while /usr/include/ufs/ffs/fs.h

#define MAXMNTLEN 468

Can we put sockets in /tmp?
Or maybe it is kind of odd to patch this because I work in paths far from /

Move unix sockets into /tmp.
Properly unset RUMP_SEVER variable every time it is exported.
@anttikantee

This comment has been minimized.

Copy link
Member

commented May 4, 2018

The reason they're in cwd is so that they don't conflict with other ongoing tests on the name host. So, at least use $$ and apply a cleanup trap if you want to move them to /tmp. rump_server (well, strictly speaking the hypercall portion of the remove syscall support) attempts to cleanup sockets when the rump kernel halts, but that of course doesn't work in case of a crash. Hence, the test script would be responsible for cleanup in "global" paths.

Also, pullup is gated on passing travis (even if the change itself didn't break travis).

@yarlB

This comment has been minimized.

Copy link
Author

commented May 5, 2018

Thank you for your answer. Something like that?
I don't know what to do about travis.

(I removed unset RUMP_SERVER because the export occurs in a subshell)

@yarlB yarlB changed the title Move unix sockets into /tmp. Properly unset RUMP_SEVER variable every time it is exported. Move unix sockets into /tmp. May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.