Browse files

librumpxen_xendev: Do not test uio->uio_offset in xenbus_dev_write

This field is undefined on entry to f_write functions.

(The copying of the file offset to and from this field is done by
vn_read and vn_write, only for vnode entries, which this isn't.)

Signed-off-by: Ian Jackson <>
  • Loading branch information...
1 parent 2f23dc0 commit ef0bfb8dbc1927c98cba185534b48cf87efa11ab @ijackson-citrix ijackson-citrix committed with ijackson-citrix Oct 7, 2016
Showing with 0 additions and 3 deletions.
  1. +0 −3 platform/xen/librumpxen_xendev/busdev.c
@@ -116,9 +116,6 @@ xenbus_dev_write(struct file *fp, off_t *offset, struct uio *uio,
DPRINTF(("/dev/xen/xenbus[%p,dd=%p]: write...\n",dc,dd));
- if (uio->uio_offset < 0)
- return EINVAL;
for (;;) { /* keep reading more until we're done */

0 comments on commit ef0bfb8

Please sign in to comment.