Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Cog and Run Test Scenarios in Circle CI #50

Merged
merged 7 commits into from Dec 15, 2019
Merged

Conversation

iamEAP
Copy link
Contributor

@iamEAP iamEAP commented Dec 15, 2019

✅ What / Why

Updates Circle CI configs so that:

  • On all branches/PRs, the Cog will be built (docker build) and go through an install/uninstall process.
    • This will help catch major issues that do not crop up in unit tests and locally-installed Cogs.
  • On all merges to master, we will run crank run ./test/scenarios
    • This will ensure that this Cog functions end-to-end in a realistic setting

It would be ideal to run all scenarios on all PRs, but unfortunately, there's no way to do so securely, as the scenarios rely on sandbox environment credentials for a handful of providers.

@iamEAP iamEAP merged commit 549cf29 into master Dec 15, 2019
@iamEAP iamEAP deleted the feat/crank-ci-cd branch December 15, 2019 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants