Skip to content

Conversation

@adrianlyjak
Copy link
Contributor

@adrianlyjak adrianlyjak commented Oct 29, 2025

Fixes some compatibility issues with llama-index-workflows >=2.9

  1. llama-index-workflows on 2.9.0 inadvertently broke most subclasses of Workflow (unhashable errors). That's been fixed upstream, and this now excludes that version
  2. The behavior of wait_for_event has changed from actually stalling the process, vs re-running the step when the event arrives. This is implemented via a specific exception to signal that the step is waiting. Some internals of workflows were catching all exceptions from the tool call, and breaking this.
  3. Need to look into this more, but bare Context's aren't supposed to be utilized except in context of a running workflow. Tests were doing this, but now I'm seeing that there's some agent related code doing this (running an agent workflow via its agent.take_step rather than a full workflow)

Fix issue with waiting for event in base agent
Fix tests improperly using Context
@adrianlyjak adrianlyjak marked this pull request as ready for review October 29, 2025 20:00
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 29, 2025
@adrianlyjak adrianlyjak force-pushed the adrian/workflow-fixes branch from 05d3c00 to f49fb8e Compare October 29, 2025 20:01
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor comment about some logging left in the PR

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2025
@logan-markewich logan-markewich merged commit 0648d2e into main Oct 29, 2025
10 of 11 checks passed
@logan-markewich logan-markewich deleted the adrian/workflow-fixes branch October 29, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants