fix: broken Log Streaming URL when working directory is set to "./" #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@chenrui.dev>
* Fix issue 1980 * Adding comment
chenrui333
changed the title
chenrui333
approved these changes
Jan 20, 2022
msarvar
reviewed
Jan 21, 2022
* Add benchmark for /healthz endpoint This benchmark will measure not only speed but also how much memory each request to /healthz allocate. I'm adding the benchmark to have a baseline to compare. Signed-off-by: Leandro López (inkel) <inkel.ar@gmail.com> * Hardcode /healthz body into a variable We know it will always be this value, there's no need to import and call json.MarshalIndent. Signed-off-by: Leandro López (inkel) <inkel.ar@gmail.com> * Initialize /healthz body only once Signed-off-by: Leandro López (inkel) <inkel.ar@gmail.com>
msarvar
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll eventually be moving to a UUID based log-streaming job identifier, removing any dependencies on the project name or the directory. So, replacing the "." character with a "_" as a temporary fix!
#1993