Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to terraform v0.12.1 #664

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@chenrui333
Copy link
Contributor

commented Jun 6, 2019

Upgrade terraform to the latest offering, v0.12.1 馃槃

@@ -620,7 +620,7 @@ tfe-token: my-token
"CHECKOUT_STRATEGY": "branch",
"DATA_DIR": "/override-path",
"DISABLE_APPLY_ALL": "false",
"DEFAULT_TF_VERSION": "v0.12.0",
"DEFAULT_TF_VERSION": "v0.12.1",

This comment has been minimized.

Copy link
@lkysow

lkysow Jun 6, 2019

Member

please don't do a search and replace. It doesn't need to be changed in these tests.

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Jun 7, 2019

Author Contributor

Sure, I will just update the necessary changes :) Sorry for the confusion.

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Jun 7, 2019

Author Contributor

Hi @lkysow, on a second thought, I think it might be good to keep the version all replaced with v0.12.1.

Keeping both 0.12.0 and 0.12.1 in the codebase might cause some confusion.

Let me know what is your thought, I can update the PR accordingly.

This comment has been minimized.

Copy link
@lkysow

lkysow Jun 7, 2019

Member

Please just update the 3 files like in this PR: https://github.com/runatlantis/atlantis/pull/400/files

I don't think it causes confusion, those are just tests. There are many version strings throughout the codebase that are needed to be there. In fact on the next version update, there will be less confusion since there will be less instances of 0.12.1 that match a search.

@lkysow

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Closed by #667

@lkysow lkysow closed this Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.