Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker image metadata #731

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@chenrui333
Copy link
Contributor

commented Aug 11, 2019

Pull the docker image information from microbadger.

image

README.md Outdated
@@ -28,5 +28,7 @@ Runs `terraform plan` and `apply` remotely and comments back on the pull request
[![Go Report Card](https://goreportcard.com/badge/github.com/runatlantis/atlantis)](https://goreportcard.com/report/github.com/runatlantis/atlantis)
[![codecov](https://codecov.io/gh/runatlantis/atlantis/branch/master/graph/badge.svg)](https://codecov.io/gh/runatlantis/atlantis)
[![CircleCI](https://circleci.com/gh/runatlantis/atlantis/tree/master.svg?style=shield)](https://circleci.com/gh/runatlantis/atlantis/tree/master)
[![Docker Image Metadata](https://images.microbadger.com/badges/image/runatlantis/atlantis.svg)](https://microbadger.com/images/runatlantis/atlantis)
[![Docker Image Version](https://images.microbadger.com/badges/version/runatlantis/atlantis.svg)](https://microbadger.com/images/runatlantis/atlantis)

This comment has been minimized.

Copy link
@lkysow

lkysow Aug 12, 2019

Member

I don't think this badge is useful, it will always say latest

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Aug 12, 2019

Author Contributor

I can update to these two:

[![Docker Image Metadata](https://images.microbadger.com/badges/image/runatlantis/atlantis:v0.8.3.svg)](https://microbadger.com/images/runatlantis/atlantis:v0.8.3)
[![Docker Image Version](https://images.microbadger.com/badges/version/runatlantis/atlantis:v0.8.3.svg)](https://microbadger.com/images/runatlantis/atlantis:v0.8.3)

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Aug 12, 2019

Author Contributor

Let me know which one do you preferred.
Docker Image Metadata
Docker Image Version

Also, looks like there is some image size issue.

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Aug 12, 2019

Author Contributor

The root cause of the versioned tag missing (not same as latest) is because:

The latest docker container is always the latest branch, while the versioned docker image is per release.

This comment has been minimized.

Copy link
@lkysow

lkysow Aug 13, 2019

Member
  • I think the layers one is cool but if it's broken, aka always showing 0B then don't think it's worth having.
  • The version one will require updating on every release. I want to move towards CI/CD based releasing which will be harder if we also have to write a commit to the README so I don't think that one is worth having.

@lkysow lkysow self-assigned this Aug 12, 2019

@codecov

This comment has been minimized.

Copy link

commented Aug 21, 2019

Codecov Report

Merging #731 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #731      +/-   ##
=========================================
- Coverage   72.25%   72.2%   -0.05%     
=========================================
  Files          62      61       -1     
  Lines        4728    4652      -76     
=========================================
- Hits         3416    3359      -57     
+ Misses       1057    1046      -11     
+ Partials      255     247       -8
Impacted Files Coverage Δ
server/events/vcs/bitbucketcloud/client.go 40% <0%> (-7.33%) ⬇️
server/events/project_command_builder.go 82.35% <0%> (-0.67%) ⬇️
cmd/server.go 79.02% <0%> (-0.41%) ⬇️
server/events/models/models.go 74.6% <0%> (ø) ⬆️
server/events/runtime/runtime.go 78.94% <0%> (ø) ⬆️
server/user_config.go 100% <0%> (ø) ⬆️
server/events/git_cred_writer.go
server/events/comment_parser.go 95.31% <0%> (+0.11%) ⬆️
server/server.go 65.82% <0%> (+1.82%) ⬆️
server/events/terraform/terraform_client.go 79.89% <0%> (+1.83%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebebe5...b5355c5. Read the comment docs.

@lkysow

lkysow approved these changes Aug 21, 2019

@lkysow lkysow merged commit 1fb16b1 into runatlantis:master Aug 21, 2019

0 of 3 checks passed

ci/circleci: test CircleCI is running your tests
Details
ci/circleci: website_link_check CircleCI is running your tests
Details
deploy/netlify Deploy preview processing.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.