-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize buttons for marking messages read/unread and flagged/unflagged #632
Comments
Which would also only toggle the appropriate messages? That is if I select a bunch, some of which are flagged, and some unflagged, and choose "Mark as .. Flagged", we only flip the status of the unflagged ones? |
I believe that would be the best way to do it. If few messages are selected, then toggle only the ones that have a different status than the one we want them to have. |
In working on this one I picked some icons from the material icons library - mark_email_unread, mark_email_read, outlined_flag etc.. however the font we are using, from npm material-design-icons , doesn't include these (not updated since 2016!).. in fact google hasn't updated the downloadable font files since then (sigh) .. I can get the icons if I link directly to https://fonts.googleapis.com/icon?family=Material+Icons however I don't know if we want to do that.. Otherwise I've found a different module with community fonts - materialdesignicons.com @gtandersen opinions? something uptodate would be nice. |
@castaway We shouldn't use externally sourced fonts for privacy reasons. The community library at http://materialdesignicons.com/ looks extensive with a style identical to that of the original MD library (while using the same icon names), so substituting our current set with this one should be a good idea. |
Also ensures that updates to the read/unread status from elsewhere picked up by the index are reflected onscreen. * runbox#632, runbox#448, runbox#537
Deployed |
In the message list and in opened messages there is currently one message action button for toggling messages as read/unread, and another for flagged/unflagged.
This is confusing and unreliable, especially when selecting multiple messages with different read and flag status.
A better solution could be to add one button for each of
read
,unread
,flagged
,unflagged
, and gather them as sub-menu items under a mainMessage status
orMark as...
button (similar to Runbox 6).The button could for instance look like this:

Separate buttons for each of the 4 actions should more clearly indicate which status is being selected and which action is being taken, while not increasing the space consumed by the menu.
Ref #448, #512, #537.
The text was updated successfully, but these errors were encountered: