New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use latest API version by default, or negotiate w/ server #126

Closed
gschueler opened this Issue Oct 11, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@gschueler
Member

gschueler commented Oct 11, 2017

Some features only work on newer API version with Rundeck. Some clients are running older version of rundeck.

We should keep the "default" API version at the latest supported level. If the server doesn't support that newer version, the User should define RD_URL=http://server/api/X where X is the latest supported version for their server.

Ideally, if using a bare RD_URL=http://server/rundeck URL (without specifying API version), rd should detect the latest supported API version by the Rundeck server and then use the latest specific API version that is commonly supported.

@Alveel

This comment has been minimized.

Show comment
Hide comment
@Alveel

Alveel Oct 23, 2017

Contributor

Hi, sorry for reopening this issue, but it seems the auto-downgrading functionality doesn't properly work.

Using Rundeck 2.3.9 (API version 20) and rundeck-cli 1.0.20, with "export RD_API_DOWNGRADE=true" in rd.conf, I still get
Error: Unsupported API Version "21". API Request: /api/21/project/$project/jobs. Reason: Current version: 20

Setting the RD_URL to include /api/20 works, though 😃

Contributor

Alveel commented Oct 23, 2017

Hi, sorry for reopening this issue, but it seems the auto-downgrading functionality doesn't properly work.

Using Rundeck 2.3.9 (API version 20) and rundeck-cli 1.0.20, with "export RD_API_DOWNGRADE=true" in rd.conf, I still get
Error: Unsupported API Version "21". API Request: /api/21/project/$project/jobs. Reason: Current version: 20

Setting the RD_URL to include /api/20 works, though 😃

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Oct 23, 2017

Member

@Alveel ok, thanks I will try to reproduce it

Member

gschueler commented Oct 23, 2017

@Alveel ok, thanks I will try to reproduce it

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Oct 23, 2017

Member

@Alveel which version do you have? did you mean 2.9.3?

Member

gschueler commented Oct 23, 2017

@Alveel which version do you have? did you mean 2.9.3?

@Alveel

This comment has been minimized.

Show comment
Hide comment
@Alveel

Alveel Oct 23, 2017

Contributor

@gschueler correct, I am on version 2.9.3-1, sorry :)

Contributor

Alveel commented Oct 23, 2017

@gschueler correct, I am on version 2.9.3-1, sorry :)

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Oct 23, 2017

Member

figured ;) I discovered the issue, not all of the api calls were using the same interface to do so, so it wasn't hooking into the downgrade mechanism

Member

gschueler commented Oct 23, 2017

figured ;) I discovered the issue, not all of the api calls were using the same interface to do so, so it wasn't hooking into the downgrade mechanism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment