New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"rd" command should allow selection of config file #72

Closed
nkadel-skyhook opened this Issue Feb 7, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@nkadel-skyhook

nkadel-skyhook commented Feb 7, 2017

Thanks for adding the "APP_CONFIG" file, it's useful.

I've noticed that the APP_CONFIG file is fairly hardcoded to $HOME/.$APP_NAME/$APP_NAME.conf . This makes it quite difficult to select an alternate configuration to speak with a distinct Rundeck server or distinct credentials in an automated fashion. I'd be happy to submit a patch to use "getopts" and support a "-c configfile"option if it's welcome. Alternatively, the various hardcoded values in the rd shell script can use this kind of structure.

DEFAULT_JVM_OPTS="${DEFAULT_JVM_OPTS:-"
APP_CONFIG=${APP_CONFIG:-$HOME/.$APP_NAME/$APP_NAME.conf}

and the like. I'd want to set APP_CONFIG to be a more rundeck specific variable to avoid overlap. And I'll be happy to submit a patch for whichever is preferred.

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Feb 7, 2017

Member

something like this would probably be best:

APP_CONFIG=${RD_CONF_FILE:-$HOME/.$APP_NAME/$APP_NAME.conf}

Might as well change APP_CONFIG to be RD_CONF_FILE as well

Member

gschueler commented Feb 7, 2017

something like this would probably be best:

APP_CONFIG=${RD_CONF_FILE:-$HOME/.$APP_NAME/$APP_NAME.conf}

Might as well change APP_CONFIG to be RD_CONF_FILE as well

@nkadel-skyhook

This comment has been minimized.

Show comment
Hide comment
@nkadel-skyhook

nkadel-skyhook Feb 7, 2017

I like it. Do you need a pull request for it?

nkadel-skyhook commented Feb 7, 2017

I like it. Do you need a pull request for it?

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Feb 7, 2017

Member

sure, that would be helpful, thank you

Member

gschueler commented Feb 7, 2017

sure, that would be helpful, thank you

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Jul 6, 2017

Member

ping @nkadel-skyhook wondering if you were able to make this change, thanks

Member

gschueler commented Jul 6, 2017

ping @nkadel-skyhook wondering if you were able to make this change, thanks

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Aug 10, 2017

Member

closing due to lack of interest, please reopen if you would like, thanks.

Member

gschueler commented Aug 10, 2017

closing due to lack of interest, please reopen if you would like, thanks.

@gschueler gschueler closed this Aug 10, 2017

@isuftin

This comment has been minimized.

Show comment
Hide comment
@isuftin

isuftin Sep 11, 2017

I would very much like to see this implemented as it would allow me to have my single Rundeck instance work against multiple remote Rundeck instances.

isuftin commented Sep 11, 2017

I would very much like to see this implemented as it would allow me to have my single Rundeck instance work against multiple remote Rundeck instances.

@gschueler gschueler reopened this Sep 11, 2017

@gschueler gschueler closed this in afd32b8 Nov 15, 2017

gschueler added a commit that referenced this issue Nov 15, 2017

Merge pull request #131 from rundeck/rundeck-cli-72
fix #72 Add RD_CONF to specify conf file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment