SCM Export: create/update job causes error: Failed to serialize job, no content was written #1931

Closed
gschueler opened this Issue Jul 6, 2016 · 1 comment

Projects

None yet

1 participant

@gschueler
Contributor

occasionally creating or saving a job fails with the error:

screenshot from 2016-07-06 12-07-58

@gschueler gschueler added the bug label Jul 6, 2016
@gschueler gschueler added this to the 2.6.9 milestone Jul 6, 2016
@gschueler
Contributor

can't find a repeatable reproduction of this issue, but based on the code I think there is a race condition when two threads attempt to serialize the same job, which can happen when a job is created/saved. one thread is triggered by the event system listening for job changes, and one by the GUI as it redirects the user to the job view page after saving.

the threads would step on each other when writing to the same temp file, and subsequently replacing the target file.

fix is to avoid writing to the same temp file, avoid writing the same job at the same time, and avoid re-serializing the job if the same or later revision has already been serialized

@gschueler gschueler self-assigned this Jul 6, 2016
@gschueler gschueler closed this in a1713b5 Jul 6, 2016
@gschueler gschueler removed the in progress label Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment