New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single valued options with "selected=true" fetched from remote URL no longer works #2854

Closed
schast opened this Issue Oct 17, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@schast

schast commented Oct 17, 2017

Issue type: Bug report

My Rundeck detail

  • Rundeck version: 2.10.0
  • install type: launcher
  • OS Name/version: RHEL 7

Actual Behavior
selected=true no longer works with single valued options since upgrade from 2.8.2 to 2.10.0.

How to reproduce Behavior
this is not working for single valued options.
i have a job with the following options:

options:
- delimiter: ','
  enforced: true
  multivalued: true
  name: node
  required: true
  values:
  - node01
  - node02
  - node03
- enforced: true
  name: product_devops-testapp
  required: true
  valuesUrl: http://localhost/cgi-bin/tmp.pl?node=${option.node.value}

the url returns the following json objects:

URL: http://localhost/cgi-bin/tmp.pl?node=node01
[
    { "value" : "testapp;00_00_01", "name" : "00_00_01" },
    { "value" : "testapp;00_00_02", "name" : "00_00_02" },
    { "value" : "testapp;00_00_03", "name" : "last installed: 00_00_03", "selected" : true }
]

URL: http://localhost/cgi-bin/tmp.pl?node=node02
[
    { "value" : "testapp;00_00_01", "name" : "00_00_01" },
    { "value" : "testapp;00_00_02", "name" : "last installed: 00_00_02", "selected" : true },
    { "value" : "testapp;00_00_03", "name" : "00_00_03" }
]

URL: http://localhost/cgi-bin/tmp.pl?node=node03
[
    { "value" : "testapp;00_00_31", "name" : "00_00_31" },
    { "value" : "testapp;00_00_32", "name" : "last installed: 00_00_32", "selected" : true },
    { "value" : "testapp;00_00_33", "name" : "00_00_33" }
]

when the first node is selected it works.
selection_002

when the second node is selected it also works.
selection_005

when the third node is selected, the first value is displayed. the selected=true value is ignored.
selection_003

after reloading the value of product_devops-testapp option, it works.
selection_004

Expected Behavior
when the third node is selected, "last installed: 00_00_32" should be displayed.

related to #2585 & #2420

@gschueler gschueler added the bug label Oct 17, 2017

@schast

This comment has been minimized.

Show comment
Hide comment
@schast

schast Nov 16, 2017

@gschueler can you please add this to milestone 2.10.1?

schast commented Nov 16, 2017

@gschueler can you please add this to milestone 2.10.1?

@gschueler gschueler added this to the 2.10.1 milestone Nov 20, 2017

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Nov 20, 2017

Member

@schast thanks for dealing with this same bug in various forms for so long 😭

Member

gschueler commented Nov 20, 2017

@schast thanks for dealing with this same bug in various forms for so long 😭

@gschueler gschueler closed this in 857c167 Nov 21, 2017

gschueler added a commit that referenced this issue Nov 21, 2017

Merge pull request #2956 from rundeck/issue/2854
Fix #2854 prevent 2way ko binding from resetting select value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment