New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of project configuration overwrites cache settings. #2993

Closed
bzlowrance opened this Issue Dec 12, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@bzlowrance

bzlowrance commented Dec 12, 2017

Issue type: Bug report

Rundeck version: Rundeck 2.10.0-1
install type: rpm
OS Name/version: RHEL 7.4
DB Type/Version: h2

When updating the project configuration, via "Edit Configuration..."the following cache settings will be overwritten with the defaults of.

project.nodeCache.delay=30
project.nodeCache.enabled=false

We use the following configuration with Ansible, and when this happens it kicks off a Gather Facts job which takes 67 minutes to complete. During this time the inventory disappears, & jobs will fail with a no nodes found error.

project.nodeCache.delay=1209600
project.nodeCache.enabled=true

With the above configuration the inventory is cached for 14 days. If an update is needed before that time, we'll kick off a node refresh job at a time that will not impact existing jobs.

I can think of a few improvements.

1 ) Do not overwrite the existing configuration settings.
2 ) Definition of the default values, for project.nodeCache.delay and project.nodeCache.enabled

If an update is made to the node configuration via "Edit Nodes..."
Only update then inventory for a new resource, or changed resource.

@gschueler gschueler added the bug label Dec 13, 2017

@gschueler gschueler added this to the 2.10.2 milestone Dec 13, 2017

@gschueler gschueler closed this in 3c47f22 Dec 15, 2017

gschueler added a commit that referenced this issue Dec 15, 2017

Merge pull request #3003 from rundeck/issue/2993
Fix #2993 node cache settings reset when saving project config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment