New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing plugin icon for provider with name containing ':' #3001

Closed
gschueler opened this Issue Dec 14, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@gschueler
Member

gschueler commented Dec 14, 2017

Issue type: Bug report

The embedded icon.png for a script plugin is not shown if the provider name contains : character.

My Rundeck detail

  • Rundeck version: 2.10.1

Expected Behavior

icon.png for a node executor plugin is displayed correctly in the Plugins list page and elsewhere

How to Reproduce

Create a zip for a script plugin, with a provider named a:test, and include a icon.png file.

The icon will not display in the Plugins list page. A 400 error is shown in the javascript console for the icon URL.

@gschueler gschueler added the bug label Dec 14, 2017

@gschueler gschueler added this to the 2.10.2 milestone Dec 14, 2017

@gschueler gschueler closed this in 1273ce4 Dec 16, 2017

gschueler added a commit that referenced this issue Dec 16, 2017

Merge pull request #3002 from rundeck/issue/3001
Fix #3001 plugin icons for providers with `:` char
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment