New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job state conditional is not working since rundeck 2.9.x #4178

Closed
jplassnibatt opened this Issue Nov 5, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@jplassnibatt

jplassnibatt commented Nov 5, 2018

Describe the bug
Job state conditional is not working as expected.
Last working version was rundeck-launcher-2.8.4.jar

My Rundeck detail

  • Rundeck version: since rundeck-launcher-2.9.1.jar
  • install type: launcher
  • OS Name/version: ubuntu 18.04
  • DB Type/version: h2

To Reproduce
See screenshots.

Expected behavior
Not keep running next steps after the job conditional fails to check condition.

Screenshots
JOB STEP CONDITION CONFIG:
captura de pantalla de 2018-11-05 13-07-07

ls script command should not be run:
captura de pantalla de 2018-11-05 13-01-30

@ahonor ahonor added the bug label Nov 6, 2018

@ahonor ahonor added this to the 3.0.9 milestone Nov 6, 2018

@jtobard jtobard self-assigned this Nov 6, 2018

@gschueler

This comment has been minimized.

Member

gschueler commented Nov 20, 2018

The plugin needs to set "Halt=true" in order to halt the workflow if the test does not match.

@jplassnibatt

This comment has been minimized.

jplassnibatt commented Nov 20, 2018

@gschueler we've tried all combinations for halt and fail check boxes in job state conditional, indeed it halt when it is selected, but the status is always "Succeeded", below is the results using the old an new 3.0.9 fix from @jtobard

  halt fail status next step
rd2 since 2.9.1 y y succeeded n
  y n succeeded n
  n y succeeded y
  n n succeeded y
rd3 fix 3.0.9 y y failed n
  y n succeeded n
  n y failed n
  n n succeeded y

gschueler added a commit that referenced this issue Nov 20, 2018

Fix #4178 propagate failure status when halting
the step result status was not being overridden by the Halt status
@gschueler

This comment has been minimized.

Member

gschueler commented Nov 20, 2018

check this update #4235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment