Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killing parent job doesn't kill running child jobs ( in 3.0.x , not able to kill parent job ) #4179

Closed
sebastianbello opened this issue Nov 5, 2018 · 1 comment

Comments

@sebastianbello
Copy link

commented Nov 5, 2018

Describe the bug
When running a Job as "Job Reference" within a Parent Job, killing the Parent Job does not kill the child job(s).
Behavior, in 3.0.x is slightly "worse": you cannot KILL parent job using the "kill job" button. However, it shows as "killed" after workflow is "completed"

My Rundeck detail

  • Rundeck version: 2.11.7 and 3.0.8
  • install type: any
  • OS Name/version: Linux, Windows
  • DB Type/version: Any

To Reproduce

  1. Create a Child Job with a single step: sleep 30 , and "On Success" notification (any) . Have this job dispatched to a remote node.

  2. Create a Parent Job that calls the Child Job as Job Reference step.

  3. Run Parent Job

  4. Kill Parent Job with the Kill Jobbutton

  5. In Rundeck 3.0.x the Job does not get "killed" when pressing "Kill Job" button. Neither is the Child Job . However, Final Status is "Killed"

  6. In Rundeck 2.11.7 the ' Parent Job** is killed , however the **Child Job** keeps running. You may note this when the "On Success" notification is received after Sleep 30. **Child Job` status appears as "Mixed".

Expected behavior
When pressing the "Kill Job" button for the Parent Job, the job should be killed, and Child Job as well.

Screenshots

RD 3.0.8 ( Parent job shown as Killed after it was "completed" )
image

On Success Notification for Child Job received AFTER execution finished ( not "killed" )
image

RD 2.11.7 ( Parent job shown as Killed after it was "completed" )
image

On Success Notification received AFTER complete execution finished ( despite showing as "killed")
image

Additional context

The same behavior occurrs when dispatching to Linux or Windows nodes and using different Node Executors, setting Target Nodes in Child Job or dispatching the workflow in Parent Job

@Daryes

This comment has been minimized.

Copy link

commented Jan 8, 2019

Though this was fixed in 2.x, but I felt on this today, having Rundeck v3.0.9 not killing its child process when running a shell command (same behavior for local or remote)

@gschueler gschueler added the bug label Jan 21, 2019

gschueler added a commit that referenced this issue Jan 28, 2019

@gschueler gschueler added this to the 3.0.14 milestone Jan 28, 2019

jessemarple added a commit that referenced this issue Jan 30, 2019

Merge pull request #4432 from rundeck/issue/4179-kill-job-ref
Fix #4179 kill job reference thread when parent is killed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.