New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grails MaxUploadSize should be configurable for Docker #4216

Closed
kirrmann opened this Issue Nov 16, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@kirrmann
Contributor

kirrmann commented Nov 16, 2018

The Docker image generates the rundeck-config.properties with each start. Because of this we cannot override the config by e.g. mounting an updated file, which is necessary to add options to successfully upload Rundeck archives larger than 25MB.

e.g.

grails.controllers.upload.maxFileSize=52428800
grails.controllers.upload.maxRequestSize=52428800

To set this options there should be corresponding ENV variables exposed or an ENV variable to include another config file (which would be the more general approach).

@ProTip

This comment has been minimized.

Contributor

ProTip commented Nov 27, 2018

Thanks @kirrmann ! I'm going to look to get this added, as well as expedite "escape hatches". Thus far the configuration plumbing is not really a public API, but I'd like to get it to where missing configuration can be more easily composed with the generated config, and perhaps even allowing generated config to be replaced more easily.

@ProTip ProTip self-assigned this Nov 27, 2018

ProTip added a commit that referenced this issue Nov 27, 2018

@ProTip ProTip added this to the 3.0.9 milestone Nov 27, 2018

@ProTip ProTip referenced this issue Nov 27, 2018

Merged

Issue/4181 #4249

@ProTip ProTip closed this in 5162146 Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment