New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UUID validation and Autocomplete in Job Reference Workflow step #4337

Closed
sebastianbello opened this Issue Dec 21, 2018 · 1 comment

Comments

Projects
None yet
4 participants
@sebastianbello
Copy link

sebastianbello commented Dec 21, 2018

**Is your feature request related to a problem?
When adding a Job Reference Workflow Step, selecting the JobName makes the UUID corresponding to the selected Job to be updated automatically. However, if you initially add the UUID to select the Job Reference, the Job Name IS NOT updated accordingly. And more, in case you update the Job Reference by changing the UUID, the selected Job ( JobName) remains unchanged and the UUID is not validated. This may cause the Job Reference to point to an invalid UUID/job or (worst scenario) to an incorrect Job ( if UUID is valid ) that may cause undesired effects.

Describe the solution you'd like
Currently, the "jobName" field auto-completes according to the Jobs available in the selected project and the UUID corresponding to the selected job fills up the "UUID" field. A solution may be to have autocomplete work the other way around, i.e. when selecting a UUID, valid options may show up and Job Name completes accordingly.

Also, a confirmation may be desired if the current selection is changed to a valid/invalid UUID.

@frachel

This comment has been minimized.

Copy link

frachel commented Dec 22, 2018

The whole way that UUID and Name are both used as the key under different circumstances seems to be an underlying issue. The whole rigmarole I have to to through doing the importing (you detailed it from my support ticket in another Issue I saw).

Is there a reason UUID is ever user-editable? Seems it should be hidden and used as the internal reference to a job everywhere. Deleting the uuid (which I have to do for a project import) now uses the Job Name as the key, so I can't change the Name of a job or the job-reference will no longer work.

The solution I'd like to see is that you never type or use the UUID (in the GUI at least) - you select a Job Reference from a dropdown, and that's it. When job details are loaded (ie, you're editing the parent job) the Job Name of the Job Reference is retrieved based on the UUID. That way if I changed the textual name of the reference Job, I'll see the new name in my steps, whereas now you see the old name.

@ahonor ahonor added the bug label Jan 7, 2019

@ahonor ahonor added this to the 3.0.12 milestone Jan 7, 2019

@jtobard jtobard self-assigned this Jan 7, 2019

jtobard added a commit that referenced this issue Jan 8, 2019

fix #4337 new error message when the jobname and the uuid of the job …
…doesnt match, preventing users to enter a wrong uuid and rely on the job name field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment