Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: popover will not disapear when selecting a node - BUG #4703

Closed
elioe opened this issue Apr 9, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@elioe
Copy link

commented Apr 9, 2019

Describe the bug

When we select a Node from a project and add it to run a command, the popover will not disappear even when the node it's already selected

My Rundeck detail

  • Rundeck version: 3.0.20
  • install type: war

To Reproduce
Steps to reproduce the behavior:

  1. Click on 'commands'
  2. Click on 'show all nodes'
  3. Select a node
  4. Popover remains visible even after selecting the node
  5. The popover disapears only when changing to another tab menu option

Expected behavior

The popover should disappear after selecting the node

Screenshots

imagen

Additional context
This behavior was not noted in 3.0.19 or earlier versions.

@gschueler gschueler added the bug label Apr 10, 2019

@gschueler gschueler added this to the 3.0.22 milestone May 9, 2019

gschueler added a commit that referenced this issue May 9, 2019

Fix #4703 node detail popup cannot be dismissed
* add knockout dom disposal callback
* constrain popup viewport to main-panel
* add mousedown handler to close popup for event outside of popup
* create unique id for interactive elements in referenced html content when copied to popup

gschueler added a commit that referenced this issue May 10, 2019

Fix #4703 node detail popup cannot be dismissed
* add knockout dom disposal callback
* constrain popup viewport to main-panel
* add mousedown handler to close popup for event outside of popup
* create unique id for interactive elements in referenced html content when copied to popup

gschueler added a commit that referenced this issue May 10, 2019

Merge pull request #4810 from rundeck/issue/4703
Fix #4703 node detail popup cannot be dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.