Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page rendering error for missing plugin #4786

Closed
ahonor opened this issue May 4, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@ahonor
Copy link
Contributor

commented May 4, 2019

Describe the bug
A plugin without a description field causes a page render error.

My Rundeck detail

  • Rundeck version: 3.1.0-snapshot
  • install type: launcher
  • OS Name/version: MacOs
  • DB Type/version: H2

To Reproduce
Steps to reproduce the behavior:

  1. Deploy a plugin that does not have a description property.
  2. Click on job view page that uses that step plugin
  3. See error

Expected behavior
The page rendering should tolerate plugins that do not have a description property.

Screenshots

image

The following is written to the service.log

Caused by: org.grails.taglib.GrailsTagException: [views/execution/_wfItemView.gsp:77] Error executing tag <stepplugin:display>: Cannot get property 'description' on null object
	at org.grails.gsp.GroovyPage.throwRootCause(GroovyPage.java:473)
	at org.grails.gsp.GroovyPage.invokeTag(GroovyPage.java:415)
	at gsp_rundeck_execution_wfItemView_gsp.run(gsp_rundeck_execution_wfItemView_gsp.groovy:129)
	at org.grails.gsp.GroovyPageWritable.doWriteTo(GroovyPageWritable.java:162)
	at org.grails.gsp.GroovyPageWritable.writeTo(GroovyPageWritable.java:82)
	at org.grails.web.gsp.GroovyPagesTemplateRenderer.makeTemplate(GroovyPagesTemplateRenderer.java:232)
	at org.grails.web.gsp.GroovyPagesTemplateRenderer.render(GroovyPagesTemplateRenderer.java:113)
	at org.grails.plugins.web.taglib.RenderTagLib$_closure7.doCall(RenderTagLib.groovy:367)
	at org.grails.gsp.GroovyPage.invokeTagLibClosure(GroovyPage.java:446)
	at org.grails.gsp.GroovyPage.invokeTag(GroovyPage.java:364)
	... 139 common frames omitted
Caused by: java.lang.NullPointerException: Cannot get property 'description' on null object
	at rundeck.services.FrameworkService.getStepPluginDescription(FrameworkService.groovy:744)
	at rundeck.services.FrameworkService.getPluginDescriptionForItem(FrameworkService.groovy:720)
	at rundeck.PluginTagLib$_closure1.doCall(PluginTagLib.groovy:32)
	at org.grails.gsp.GroovyPage.invokeTagLibClosure(GroovyPage.java:446)
	at org.grails.gsp.GroovyPage.invokeTag(GroovyPage.java:364)
	... 147 common frames omitted

Desktop (please complete the following information):

  • OS: MacOs
  • Browser Firefox
  • Version: newest

@ahonor ahonor added the bug label May 4, 2019

@gschueler gschueler self-assigned this May 9, 2019

@gschueler gschueler added this to the 3.0.22 milestone May 9, 2019

@gschueler gschueler changed the title Page rendering error due to bad plugin Page rendering error for missing plugin May 9, 2019

@gschueler

This comment has been minimized.

Copy link
Member

commented May 9, 2019

This occurs if a workflow is defined using a step plugin that is no longer installed

gschueler added a commit that referenced this issue May 9, 2019

gschueler added a commit that referenced this issue May 10, 2019

gschueler added a commit that referenced this issue May 10, 2019

Merge pull request #4812 from rundeck/issue/4786
Fix #4786 page error for missing plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.