Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: When editing a job, errors are not clearly shown. #5000

Closed
sebastianbello opened this issue Jun 26, 2019 · 0 comments

Comments

@sebastianbello
Copy link

commented Jun 26, 2019

Describe the bug
When editing a job and saving it, you sometimes get errors in any of the job`s tabs. You are not allowed to save, not being able to see where is the error is without going through all the tabs.

My Rundeck detail

  • Rundeck version: 3.1.0 RC1
  • install type: Any

To Reproduce
Steps to reproduce the behavior:

  1. Edit any Job
  2. Click on 'Workflow' tab
  3. Scroll down to any 'workflow step' and click to edit. Do not close it.
  4. Go back to any other tab and 'Save' ( no error is shown, not allowing to save)
  5. Go back to the ' offending' tab and click 'save' ( the error is highlighted as expected ).

Expected behavior
A pop-up or other message may be shown, pointing to the offending ' tab' and/or ' error', regardless of which tab is currently active.

Screenshots

image
( the 'Save' button is pressed, no action performed, no error message shown)

image
( after browsing all the tabs, the error may be noted and is highlighted if 'save' is selected here)

@gschueler gschueler added this to the 3.1.0-RC2 milestone Jun 27, 2019

jessemarple added a commit that referenced this issue Jul 2, 2019

Merge pull request #5014 from rundeck/rundeck-5000
Fix #5000 highlight workflow editor unsaved changes issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.