Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak: git scm plugin accessed via API #5301

Closed
gschueler opened this issue Sep 26, 2019 · 2 comments · Fixed by #5304

Comments

@gschueler
Copy link
Member

commented Sep 26, 2019

Describe the bug

Rundeck fails with OOM error after running for a while. Heap dump indicates SCM service is causing a memory leak. Code paths indicate API calls for scm status may cause the leak.

My Rundeck detail

  • Rundeck version: 3.0.x

To Reproduce
Steps to reproduce the behavior:

(untested)

  1. Enable git scm plugin for project(s)
  2. Repeatedly use API to query scm status of project/jobs
  3. observe memory usage increasing

Expected behavior

Repeated SCM Status API calls should not increase memory usage

@gschueler gschueler added the bug label Sep 26, 2019
@gschueler gschueler self-assigned this Sep 26, 2019
gschueler added a commit that referenced this issue Sep 26, 2019
* prevents multiple listeners for the same project+integration plugin
from accumulating after repeated scm status queries
* same when scm plugins are re-enabled or re-configured
gschueler added a commit that referenced this issue Sep 27, 2019
Fix #5301 fix initProject, and clean old listeners
@gschueler gschueler added this to the Sprint 40 milestone Sep 27, 2019
@gschueler

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2019

needs backport: 3.0

@gschueler

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2019

needs backport: 2.x

gschueler added a commit that referenced this issue Sep 27, 2019
* prevents multiple listeners for the same project+integration plugin
from accumulating after repeated scm status queries
* same when scm plugins are re-enabled or re-configured
gschueler added a commit that referenced this issue Sep 27, 2019
* prevents multiple listeners for the same project+integration plugin
from accumulating after repeated scm status queries
* same when scm plugins are re-enabled or re-configured
gschueler added a commit that referenced this issue Sep 30, 2019
* prevents multiple listeners for the same project+integration plugin
from accumulating after repeated scm status queries
* same when scm plugins are re-enabled or re-configured
gschueler added a commit that referenced this issue Oct 1, 2019
* prevents multiple listeners for the same project+integration plugin
from accumulating after repeated scm status queries
* same when scm plugins are re-enabled or re-configured
gschueler added a commit that referenced this issue Oct 1, 2019
[2.11 backport] Fix #5301 fix initProject, and clean old listeners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.