Job option names are not modifiable in 1.6.1+ #559

Closed
michaelgibson opened this Issue Sep 30, 2013 · 4 comments

Comments

Projects
None yet
4 participants
@michaelgibson

Confirmed by Alex in IRC.

Steps to reproduce.
Create new job or edit existing job on 1.6.1+ and try to use backspace or arrow keys within the job option name textarea.
Result is that the text is not removed.
No errors in the JS console that I can see.

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Sep 30, 2013

Member

thanks, can you post your os/browser details?

Member

gschueler commented Sep 30, 2013

thanks, can you post your os/browser details?

@ahonor

This comment has been minimized.

Show comment
Hide comment
@ahonor

ahonor Sep 30, 2013

Contributor

From IRC: "michaelgibson: I use Firefox in linux mainly but have reproduced in Chrome, and IE in windows."

I reproduced problem with Firefox on Macosx

Contributor

ahonor commented Sep 30, 2013

From IRC: "michaelgibson: I use Firefox in linux mainly but have reproduced in Chrome, and IE in windows."

I reproduced problem with Firefox on Macosx

@coderanger

This comment has been minimized.

Show comment
Hide comment
@coderanger

coderanger Mar 27, 2014

Still happening in 2.0.3 on Firefox 28.

Still happening in 2.0.3 on Firefox 28.

@coderanger

This comment has been minimized.

Show comment
Hide comment
@coderanger

coderanger Mar 27, 2014

The issue is mostly likely here

elem.observe('keypress', onlychars.curry('[a-zA-Z_0-9.\\t-]'));

Should be extended to allow control chars.

The issue is mostly likely here

elem.observe('keypress', onlychars.curry('[a-zA-Z_0-9.\\t-]'));

Should be extended to allow control chars.

@ahonor ahonor modified the milestones: 2.0.4, 1.6.3 Mar 29, 2014

gschueler added a commit that referenced this issue Apr 10, 2014

delete key in option name field not blocked #559
* checked with firefox, IE, chrome, safari

gschueler added a commit that referenced this issue Apr 11, 2014

delete key in option name field not blocked #559
* checked with firefox, IE, chrome, safari

@gschueler gschueler removed the needs-review label Apr 18, 2014

@gschueler gschueler closed this Apr 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment