Add text/plain MIME type for YAML files #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The currently specified MIME types "*/yaml", "*/x-yaml" are not generally found on any popular web server. See http://www.iana.org/assignments/media-types/media-types.xhtml . Consequentially, the MIME type returned for a YAML file hosted via a common web server is text/plain . This change shouldn't affect XML files served since they do have a globally accepted MIME type and will be served with that in the header. Facing issues with being able to serve such a file off a shared service. Seeing... ERROR ExceptionCatchingResourceModelSource: [ResourceModelSource: 1.url (URL Source), project: XYZ] com.dtolabs.rundeck.core.resources.ResourceModelSourceException: Error requesting URL Resource Model Source: http://f.q.d.n/xyz.yaml: Response content type is not supported: text/plain Caused by: com.dtolabs.rundeck.core.resources.format.UnsupportedFormatException: No provider available to parse MIME type: text/plain at com.dtolabs.rundeck.core.resources.format.ResourceFormatParserService.getParserForMIMEType(ResourceFormatParserService.java:193) at com.dtolabs.rundeck.core.resources.URLResourceModelSource.getNodes(URLResourceModelSource.java:309) ...in the logs.
new23d
changed the title
|
thanks. The patterns used |
gschueler
changed the title
gschueler
added a commit
that referenced
this pull request
Mar 13, 2015
Add text/plain MIME type for YAML files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently specified MIME types "/yaml", "/x-yaml" are not generally found on any popular web server. See http://www.iana.org/assignments/media-types/media-types.xhtml . Consequentially, the MIME type returned for a YAML file hosted via a common web server is text/plain . This change shouldn't affect XML files served since they do have a globally accepted MIME type and will be served with that in the header.
Facing issues with being able to serve such a file off a shared service. Seeing...
...in the logs.