New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job Reference on another Project #2519

Merged
merged 6 commits into from Jun 12, 2017

Conversation

Projects
None yet
2 participants
@jtobard
Contributor

jtobard commented May 18, 2017

Added capability to use Job Reference step referencing another project.
The current behavior is maintained leaving the field empty ensuring backward compatibility.

New create/edit GUI:
screenshot at may 18 13-51-57

Autocomplete of allowed projects:
screenshot at may 18 13-52-26
If the user has no permission to see another project will not be displayed on autocomplete.
Choose A Job... button will show the entered project jobs if the field is completed. On empty field, continue to show current project jobs.

If the project field is filled with an unauthorized project or a non existent one this error will be displayed:
screenshot at may 18 13-53-20

New text string representation on screen of Job reference from another project:
screenshot at may 18 13-54-09

See #561

@gschueler gschueler added this to the 2.9.0 milestone Jun 8, 2017

@gschueler gschueler added the next-minor label Jun 8, 2017

@gschueler gschueler changed the base branch from master to prerelease-2.9.0 Jun 9, 2017

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Jun 12, 2017

Member

the job reference execution works

there are a few things I noticed:

  • in the workflow editor, when you type in a bad project name: the job picker when you click Select
  • there could be a dropdown/select for the project name, instead of typing it in
  • in the Job show/execution show page for a job with a job reference to another project, there are also some GUI issues:
    • job reference's workflow does not get used in the UI for steps. This is likely a javascript issue
Member

gschueler commented Jun 12, 2017

the job reference execution works

there are a few things I noticed:

  • in the workflow editor, when you type in a bad project name: the job picker when you click Select
  • there could be a dropdown/select for the project name, instead of typing it in
  • in the Job show/execution show page for a job with a job reference to another project, there are also some GUI issues:
    • job reference's workflow does not get used in the UI for steps. This is likely a javascript issue

@gschueler gschueler merged commit 708f688 into rundeck:prerelease-2.9.0 Jun 12, 2017

@gschueler gschueler removed the in progress label Jun 12, 2017

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Jun 13, 2017

Member

@jtobard can you look into those issues?

Member

gschueler commented Jun 13, 2017

@jtobard can you look into those issues?

@jtobard

This comment has been minimized.

Show comment
Hide comment
@jtobard

jtobard Jun 13, 2017

Contributor
Contributor

jtobard commented Jun 13, 2017

#2562

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment