New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Gradle 3.5 #2600

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
2 participants
@ReneKroon

I am trying to find why our project pages are not loading that fast. Since i'm not too familiar with the source and Groovy, i decided to work from the outside in.

This pull-request updates gradle so that it becomes easier to start updating Grails as well. That in turn means that development will become easier since questions, issues and FAQ's will be up to date.

Note that this pull requests also fixes some unit tests which were disabled and gradle 3.5 did not allow it.

Please let me know if you would also appreciate a grails update.

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Jun 30, 2017

Member

@ReneKroon thank you! we do want to upgrade to grails 3, i have done some work on that front, however it is not complete. There are a few major technical issues, I think. If you want to give it a shot, take a look at this branch: https://github.com/gschueler/rundeck/tree/grails3 It is out of synch with master, and we have ongoing work in the prerelease-2.9.0 branch which will be merged to master on its release. So I was postponing any further grails3 work until that is complete.

My process was sort of odd because i created a grails3 project from scratch and began piecemeal copying things over to the new project. Maybe it would be better to take what I learned from that and apply it to the existing rundeckapp grails project. If you have experience doing a grails3 upgrade I would appreciate the help!

Member

gschueler commented Jun 30, 2017

@ReneKroon thank you! we do want to upgrade to grails 3, i have done some work on that front, however it is not complete. There are a few major technical issues, I think. If you want to give it a shot, take a look at this branch: https://github.com/gschueler/rundeck/tree/grails3 It is out of synch with master, and we have ongoing work in the prerelease-2.9.0 branch which will be merged to master on its release. So I was postponing any further grails3 work until that is complete.

My process was sort of odd because i created a grails3 project from scratch and began piecemeal copying things over to the new project. Maybe it would be better to take what I learned from that and apply it to the existing rundeckapp grails project. If you have experience doing a grails3 upgrade I would appreciate the help!

@ReneKroon

This comment has been minimized.

Show comment
Hide comment
@ReneKroon

ReneKroon Jun 30, 2017

Thanks for the update. Can this be merged already as separate PR? or do i need to target a different branch than master?

Thanks for the update. Can this be merged already as separate PR? or do i need to target a different branch than master?

@gschueler

This comment has been minimized.

Show comment
Hide comment
@gschueler

gschueler Jun 30, 2017

Member

@ReneKroon I will merge it after we perform the next release

Member

gschueler commented Jun 30, 2017

@ReneKroon I will merge it after we perform the next release

@gschueler gschueler added this to the 2.8.4 milestone Jun 30, 2017

@gschueler gschueler merged commit 1dc2f5b into rundeck:master Jul 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ReneKroon ReneKroon deleted the bolcom:gradle3.5 branch Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment