New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Services to the DynamicProperties interface #4180

Merged
merged 11 commits into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@miguelantonio
Contributor

miguelantonio commented Nov 6, 2018

Adding StorageTree to the DynamicProperties interface, in order to access to the key storage on the dynamicProperties plugin implementation.

miguelantonio and others added some commits Nov 6, 2018

Adding StorageTree to the DynamicProperties interface, in order to ac…
…cess to the key storage on the dynamicProperties plugin implementation.
Merge pull request #4185 from rundeck/fix/plugin-notfound
Fix: 500 error for pluginDetail if plugin not found
@gschueler

This comment has been minimized.

Member

gschueler commented Nov 8, 2018

@miguelantonio i will make some changes to this

@miguelantonio

This comment has been minimized.

Contributor

miguelantonio commented Nov 8, 2018

@gschueler got it, thank you!

@gschueler

This comment has been minimized.

Member

gschueler commented Nov 8, 2018

@miguelantonio the way this works is, you can use this new method https://github.com/rundeck/rundeck/pull/4180/files#diff-ad4d8f1bcc471417c976f3ab418d8888R27

which supplies a Services object. this can give you the key storage, by calling services.getService(KeyStorageTree)

@gschueler gschueler changed the title from Adding StorageTree to the DynamicProperties interface to Adding Services to the DynamicProperties interface Nov 8, 2018

@gschueler gschueler added this to the 3.0.9 milestone Nov 13, 2018

@gschueler gschueler merged commit 95030af into rundeck:master Nov 15, 2018

18 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment