New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3452 and #3987 by adding a login module that can hot reload realm.properties #4194

Merged
merged 2 commits into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@sjrd218
Contributor

sjrd218 commented Nov 9, 2018

Jetty PropertyUserStore has a hot reload flag, but the default Jetty property file login module doesn't set it. This PR adds a module that sets the flag when the module is initialized.

Fix #3452 and #3987 by adding a login module that uses the hot reload…
… feature of the Jetty PropertyUserStore.
@AWKIF

This comment has been minimized.

AWKIF commented Nov 15, 2018

Great! thanks for your work
Please merge this and add some doc on how to use it 👍

@gschueler

I think just remove an unneeded logger.error call

@gschueler

This comment has been minimized.

Member

gschueler commented Nov 20, 2018

The "PropertyFileLoginModule" docs are kind of limited, and don't show a default config. I think the "hotReload" at least should be mentioned, however: https://rundeck.org/docs/administration/security/authenticating-users.html#propertyfileloginmodule

@sjrd218

This comment has been minimized.

Contributor

sjrd218 commented Nov 20, 2018

Here's the commit that was merged a few days ago that documents the hotReload property.

rundeck/docs@5890841

@gschueler

This comment has been minimized.

Member

gschueler commented Nov 20, 2018

@sjrd218 thanks. missed that change

@gschueler gschueler added this to the 3.0.9 milestone Nov 21, 2018

@gschueler gschueler merged commit a9d1d4e into master Nov 21, 2018

19 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment