New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camelcase keys in remco template for docker image #4207

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@kirrmann
Contributor

kirrmann commented Nov 14, 2018

This fixes #4203

Env Variables in the remco template were referenced with camelcase keys which doesn't work. They have to be lowercase. Without this fix the default value for getv is always used.

@ProTip ProTip self-assigned this Nov 27, 2018

@ProTip ProTip added this to the 3.0.9 milestone Nov 27, 2018

@ProTip

This comment has been minimized.

Contributor

ProTip commented Nov 27, 2018

Hi @kirrmann , thanks for the submission! I believe this should be good to merge after the one suggestion is merged.

Fix usefirstpass getv key
Co-Authored-By: kirrmann <kirrmann@users.noreply.github.com>

@ProTip ProTip merged commit 1671678 into rundeck:master Nov 27, 2018

18 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

@kirrmann kirrmann deleted the kirrmann:patch-1 branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment