New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution Metrics API #4317

Merged
merged 37 commits into from Jan 18, 2019

Conversation

Projects
None yet
5 participants
@ahormazabal
Copy link
Contributor

ahormazabal commented Dec 18, 2018

created two new API endpoints:
/api/V/project/[PROJECT]/executions/metrics
/api/V/executions/metrics (system-wide variant)

Both APIs receive the same parameters as the Execution Query API, but returns statistics over the execution resultset instead of returning the actual executions.

Current stats implemented:

  • Count of total executions.
  • Count by each execution state
  • Average execution duration.
  • Maximum execution duration.
  • Minimum execution duration.
@gschueler

This comment has been minimized.

Copy link
Member

gschueler commented Dec 21, 2018

Looks good to me, can you add API documentation with a PR to @rundeck/docs ?

ahormazabal and others added some commits Dec 23, 2018

Fixes #115. Null or empty passwords are disallowed which fixes the bu…
…g. An additional condition

was added to check for an empty char array being provided as the password.
@ahormazabal

This comment has been minimized.

Copy link
Contributor Author

ahormazabal commented Jan 4, 2019

Added documentation on PR rundeck/docs#192.
Also i have updated the branch to be mergeable with master.

@ahormazabal

This comment has been minimized.

Copy link
Contributor Author

ahormazabal commented Jan 4, 2019

Please also review the corresponding CLI commands on rundeck/rundeck-cli#210

gschueler and others added some commits Jan 7, 2019

Merge pull request #4355 from rundeck/issue/2975
Fix #2975 multiple threads modify the map
Merge pull request #4338 from rundeck/issue/946
User profile information can be sync'd from LDAP
Merge pull request #4373 from rundeck/exp/plugin-validate-endpoint
Add ajax endpoint for plugin validation

jtobard and others added some commits Jan 14, 2019

new transaction for jos statistics, disable jobref stats using frame…
…work.properties rundeck.disable.ref.stats=true
Merge pull request #4388 from rundeck/fix/jobref-stats-3-0-11
Fix #4302 deadlock and allow disabling jobref stats
@gschueler

This comment has been minimized.

Copy link
Member

gschueler commented on e2b3b61 Jan 16, 2019

perhaps we should consolidate this into gradle.properties at some point, only have to make 1 file change then for version update

This comment has been minimized.

Copy link
Member

gschueler replied Jan 16, 2019

gschueler added some commits Jan 16, 2019

Merge pull request #4379 from rundeck/issue/repo-ui-plugins-show-unin…
…stalled

UI plugin install status fix
Merge pull request #4378 from rundeck/issue/4374
Fix #4374. User and role set by AJP were not being properly set.
Merge pull request #4371 from ahormazabal/dev/springsec-upversion
Update spring security plugin to last version.
@gschueler

This comment has been minimized.

Copy link
Member

gschueler commented Jan 17, 2019

@ahormazabal i've played with the changes a bit, I think I will update it with these changes if you don't mind:

change the output model:

{
  "duration": {
    "average": "1s",
    "min": "0s",
    "max": "39s"
  },
  "total": 97,
  "status": {
    "failed-with-retry": 48,
    "aborted": 1,
    "failed": 16,
    "succeeded": 32
  }
}
@ahormazabal

This comment has been minimized.

Copy link
Contributor Author

ahormazabal commented Jan 17, 2019

looks great!

@gschueler

This comment has been minimized.

Copy link
Member

gschueler commented Jan 18, 2019

todos

  • update docs
  • update rd tool

@gschueler gschueler added this to the 3.0.13 milestone Jan 18, 2019

@gschueler gschueler merged commit 881299d into rundeck:master Jan 18, 2019

19 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment