New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

email notification enhancement #4365

Merged
merged 3 commits into from Jan 22, 2019

Conversation

Projects
None yet
2 participants
@ltamaster
Copy link
Contributor

ltamaster commented Jan 8, 2019

Are you implementing a feature or enhancement? enhancement

Is this a bugfix, or an enhancement? Please describe.
For #3233

Describe the solution you've implemented
Add new features to email notification

  1. pass the log output on the email body (using a new variable on the email notification called attachLogInline)
  2. when the log output is attached, define the extension of the attached file, adding new settings on rudeck-config.properties. For example:
rundeck.mail.template.log.extension=html
rundeck.mail.template.log.contentType=text/html
rundeck.mail.<PROJECT>.<JOBNAME>.template.log.extension=csv
rundeck.mail.<PROJECT>.<JOBNAME>.template.log.contentType=text/csv
rundeck.mail.<TRIGGER>.template.log.extension=html
rundeck.mail.<TRIGGER>.template.log.contentType=text/html

Additional context
screenshot 2019-01-09 16 00 04

screenshot 2019-01-09 16 01 17

@gschueler

This comment has been minimized.

Copy link
Member

gschueler commented Jan 8, 2019

It looks like the option to attach the log is now required (radio buttons), it should still be optional. e.g.:

[√] include log output
    (•) as file attachment  ( ) inline
@ltamaster

This comment has been minimized.

Copy link
Contributor Author

ltamaster commented Jan 8, 2019

Ok @gschueler, I will add that

@gschueler gschueler added this to the 3.0.12 milestone Jan 14, 2019

@gschueler gschueler merged commit 4c5a076 into master Jan 22, 2019

19 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No new issues
Details
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment